[FIX] website: fix url picker editor dropdown #97305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes 2 issues with the position of the dropdown with the suggested links in the url picker input of the snippet options. (e.g. redirect url input of the countdown snippet). 1- Before this commit the dropdown went over the input while editing the url. 2- Before this commit the position of the dropdown (when above the input) was a little too low if there were images in the dropdown. It was because the images are loaded after the positioning of the dropdown and no height was defined for these images. task-2900529
bvr-odoo
force-pushed
the
14.0-fix-url-picker-dropdown-bvr
branch
from
4986de3
to
55f6714
Compare
|
Note for forward-port: #97285 -> to solve the conflict |
qsm-odoo
approved these changes
Sep 29, 2022
robodoo
pushed a commit
that referenced
this pull request
Sep 29, 2022
This commit fixes 2 issues with the position of the dropdown with the suggested links in the url picker input of the snippet options. (e.g. redirect url input of the countdown snippet). 1- Before this commit the dropdown went over the input while editing the url. 2- Before this commit the position of the dropdown (when above the input) was a little too low if there were images in the dropdown. It was because the images are loaded after the positioning of the dropdown and no height was defined for these images. task-2900529 closes #97305 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This was referenced Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes 2 issues with the position of the dropdown with the
suggested links in the url picker input of the snippet options. (e.g.
redirect url input of the countdown snippet).
1- Before this commit the dropdown went over the input while editing the
url.
2- Before this commit the position of the dropdown (when above the
input) was a little too low if there were images in the dropdown. It was
because the images are loaded after the positioning of the dropdown and
no height was defined for these images.
task-2900529
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr