Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] website, web_editor: fix logo selector not displayed if text logo #98227

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Aug 16, 2022

Before this commit, the logo type selector was not displayed in navbar
options when the logo type was "Text".

This commit fix it only in js because we are on a stable version, an
other commit will fix it in the snippets options XML in master.

task-2800680

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #87730

Before this commit, the logo options (type, height, height scrolled)
were not displayed if the logo type was "Text".

After this commit, these options are moved to the navbar section so that
they are always displayed if the logo is "Text" or "Image". And if the
logo type is "None" only the logo type selector is displayed. Just like
it was in 14.0.

task-2800680

X-original-commit: cddf06d
Co-authored-by: qsm-odoo <qsm@odoo.com>
@robodoo
Copy link
Contributor

robodoo commented Aug 16, 2022

@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 16, 2022

This PR targets saas-15.4 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Aug 16, 2022
@C3POdoo C3POdoo added the RD research & development, internal work label Aug 16, 2022
@qsm-odoo
Copy link
Contributor

@fw-bot r+

robodoo pushed a commit that referenced this pull request Aug 17, 2022
Before this commit, the logo options (type, height, height scrolled)
were not displayed if the logo type was "Text".

After this commit, these options are moved to the navbar section so that
they are always displayed if the logo is "Text" or "Image". And if the
logo type is "None" only the logo type selector is displayed. Just like
it was in 14.0.

task-2800680

closes #98227

X-original-commit: cddf06d
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>
@robodoo robodoo temporarily deployed to merge August 17, 2022 10:38 Inactive
@robodoo robodoo closed this Aug 17, 2022
@fw-bot fw-bot deleted the saas-15.4-15.0-fix-logo-type-option-bvr-aw4s-fw branch August 31, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants