Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] account: add missing _name_search for account.move.line #98228

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Aug 16, 2022

The model had name_get, but not _name_search, which leads to difference between
display names and expected results.

This patch doesn't fix the issue completly, but adds more search results on
searching just by account move (e.g. invoice) name.

STEPS:

  • open menu Analytic Items (account.analytic.line)
  • make custom filter Journal items contains "INV/" (
    [["move_id","ilike","INV"]] )

BEFORE: no items found even if you see such analytic items


opw-2691495

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #87156

@robodoo
Copy link
Contributor

robodoo commented Aug 16, 2022

@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 16, 2022

Ping @yelizariev, @william-andre cherrypicking of pull request #87156 failed.

stderr:

20:52:23.460105 git.c:344               trace: built-in: git cherry-pick c7957fd14c4c8b1867daf60844962e4857dc7346
error: could not apply c7957fd14c4c... [FIX] account: add missing _name_search for account.move.line
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Aug 16, 2022
@robodoo robodoo added conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot labels Aug 16, 2022
The model had name_get, but not _name_search, which leads to difference between
what user sees and what he get as search results.

This patch doesn't fix the issue completly, but adds more search results on
searching just by account move (e.g. invoice) name.

STEPS:

* open menu Analytic Items (account.analytic.line)
* make custom filter *Journal items contains "INV/"* (
`[["move_id","ilike","INV"]]` )

BEFORE: no items found even if you see such analytic items

---

opw-2691495

X-original-commit: d1baf02
@william-andre william-andre force-pushed the saas-15.4-13.0-opw-2691495-account.move.line-_name_search--bugfix-IEL-O-K8-fw branch from 6d18beb to 77b7208 Compare August 17, 2022 10:56
@william-andre
Copy link
Contributor

@robodoo r+

@C3POdoo C3POdoo requested review from a team and csnauwaert and removed request for a team August 17, 2022 10:58
robodoo pushed a commit that referenced this pull request Aug 17, 2022
The model had name_get, but not _name_search, which leads to difference between
what user sees and what he get as search results.

This patch doesn't fix the issue completly, but adds more search results on
searching just by account move (e.g. invoice) name.

STEPS:

* open menu Analytic Items (account.analytic.line)
* make custom filter *Journal items contains "INV/"* (
`[["move_id","ilike","INV"]]` )

BEFORE: no items found even if you see such analytic items

---

opw-2691495

closes #98228

X-original-commit: d1baf02
Signed-off-by: William André (wan) <wan@odoo.com>
@robodoo robodoo temporarily deployed to merge August 17, 2022 12:54 Inactive
@robodoo robodoo closed this Aug 17, 2022
@fw-bot fw-bot deleted the saas-15.4-13.0-opw-2691495-account.move.line-_name_search--bugfix-IEL-O-K8-fw branch August 31, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants