Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] hr_holidays: remove allocation_id on hr.leave #98302

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Aug 17, 2022

As part of hr_holidays B2B, the holidays allowances were moved from hr_leave_type to hr_leave_allocation.
This didn't allow to take a leave longer than the maximum duration of an allocation. Also, despite all the
allocations could have enough days for a certain leave, it was not possible to use all available days without
splitting the leaves across the different allocations.

This commit moves the holidays allowance to the hr_leave_type to remediate the issues described above.

task-2834887

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #98253
Forward-Port-Of: #96545

As part of hr_holidays B2B, the holidays allowances were moved from hr_leave_type to hr_leave_allocation.
This didn't allow to take a leave longer than the maximum duration of an allocation. Also, despite all the
allocations could have enough days for a certain leave, it was not possible to use all available days without
splitting the leaves across the different allocations.

This commit moves the holidays allowance to the hr_leave_type to remediate the issues described above.

task-2834887

X-original-commit: 8c37d5c
@robodoo robodoo added the forwardport This PR was created by @fw-bot label Aug 17, 2022
@robodoo
Copy link
Contributor

robodoo commented Aug 17, 2022

@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 17, 2022

This PR targets saas-15.4 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the RD research & development, internal work label Aug 17, 2022
@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 17, 2022

@phwa-odoo the next pull request (#98317) is in conflict. You can merge the chain up to here by saying

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@phwa-odoo
Copy link

@fw-bot r+

robodoo pushed a commit that referenced this pull request Aug 17, 2022
As part of hr_holidays B2B, the holidays allowances were moved from hr_leave_type to hr_leave_allocation.
This didn't allow to take a leave longer than the maximum duration of an allocation. Also, despite all the
allocations could have enough days for a certain leave, it was not possible to use all available days without
splitting the leaves across the different allocations.

This commit moves the holidays allowance to the hr_leave_type to remediate the issues described above.

task-2834887

closes #98302

X-original-commit: 8c37d5c
Signed-off-by: phwa-odoo <phwa@odoo.com>
@robodoo robodoo temporarily deployed to merge August 17, 2022 16:13 Inactive
@robodoo robodoo closed this Aug 17, 2022
@fw-bot fw-bot deleted the saas-15.4-15.0-hr-holidays-remove-allocation-id-phwa-1CZG-fw branch August 31, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants