[FW][FIX] website: hide logo height scrolled option if no logo #98308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the logo height scrolled option was displayed even if there was no logo. It was because the condition to display or not this option (in the "_computeWidgetVisibility") had not been updated correctly when the DOM of the navbar was refactored. task-2800680 X-original-commit: 2b2ff73
|
This PR targets saas-15.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Aug 17, 2022
Before this commit, the logo height scrolled option was displayed even if there was no logo. It was because the condition to display or not this option (in the "_computeWidgetVisibility") had not been updated correctly when the DOM of the navbar was refactored. task-2800680 closes #98308 X-original-commit: 2b2ff73 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
fw-bot
deleted the
saas-15.4-14.0-fix-logo-height-scrolled-option-visibility-bvr-RBZR-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the logo height scrolled option was displayed even
if there was no logo.
It was because the condition to display or not this option (in the
"_computeWidgetVisibility") had not been updated correctly when the DOM
of the navbar was refactored.
task-2800680
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #98209
Forward-Port-Of: #87961