[FW][FIX] website_sale: prevent changing name when invoiced are issued #98333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/my/account controller blocks name/vat/company_name updating if there are issued invoices. However Before this commit, user can change name via /shop/address page STEPS 1/ install sales, eCommerce,inventory,Accounting 2/ create a sales order from the portal page, validate and create an invoice from SO and post it 3/ Try to change the name from the Portal > Account Result - not possible = correct 4/ Place a new SO by the same portal user and edit the name on the address before proceeding to checkout [1]: https://github.com/odoo/odoo/blob/1f49528a4b198e8912beb33be921d2855c694e2e/addons/account/controllers/portal.py#L111-L113 opw-2848251 X-original-commit: 3c8337d
|
This PR targets saas-15.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Aug 18, 2022
/my/account controller blocks name/vat/company_name updating if there are issued invoices. However Before this commit, user can change name via /shop/address page STEPS 1/ install sales, eCommerce,inventory,Accounting 2/ create a sales order from the portal page, validate and create an invoice from SO and post it 3/ Try to change the name from the Portal > Account Result - not possible = correct 4/ Place a new SO by the same portal user and edit the name on the address before proceeding to checkout [1]: https://github.com/odoo/odoo/blob/1f49528a4b198e8912beb33be921d2855c694e2e/addons/account/controllers/portal.py#L111-L113 opw-2848251 closes #98333 X-original-commit: 3c8337d Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>
fw-bot
deleted the
saas-15.4-13.0-opw-2848251-website_sale-name-chaning-after-invoices--bugfix-IEL-JDPN-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/my/account controller blocks name/vat/company_name updating if there are issued invoices.
However Before this commit, user can change name via /shop/address page
STEPS
1/ install sales, eCommerce,inventory,Accounting
2/ create a sales order from the portal page, validate and create an invoice from SO and post it
3/ Try to change the name from the Portal > Account
Result - not possible = correct
4/ Place a new SO by the same portal user and edit the name on the address before proceeding to checkout
opw-2848251
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #98255
Forward-Port-Of: #97686