[FW][FIX] hr_expense : mobile display quantity uom #98334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: 1. Install hr_expense,inventory 2. Enable unit of measure in the invetory setting 3. Create an expense product with a uom 4. Switch to mobile display and refresh 5. Try to create a new expense, the quantity field is not visible Cause: In 15.0 it was decided in PR odoo#68387 to switch from the selection widget to options. This changed the css of the element. Solution: Checking the entire codebase with the following regex "<div.*class="o_row".*\n.*class="oe_inline".*\n.*class="oe_inline".*\n.*<\/div>" in order to find an other usage of o_row with two inline element yielded no result other than hr_expense. In order to minimise the amount of changes, a local fix of the styling is probably more appropriate. opw-2924276 X-original-commit: 0754f71
|
This PR targets saas-15.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Aug 18, 2022
Steps to reproduce: 1. Install hr_expense,inventory 2. Enable unit of measure in the invetory setting 3. Create an expense product with a uom 4. Switch to mobile display and refresh 5. Try to create a new expense, the quantity field is not visible Cause: In 15.0 it was decided in PR #68387 to switch from the selection widget to options. This changed the css of the element. Solution: Checking the entire codebase with the following regex "<div.*class="o_row".*\n.*class="oe_inline".*\n.*class="oe_inline".*\n.*<\/div>" in order to find an other usage of o_row with two inline element yielded no result other than hr_expense. In order to minimise the amount of changes, a local fix of the styling is probably more appropriate. opw-2924276 closes #98334 X-original-commit: 0754f71 Signed-off-by: Kevin Baptiste <kba@odoo.com>
fw-bot
deleted the
saas-15.4-15.0-opw-2924276-hr_expense-mobile_display_no_quantity_uom-flvr-afZn-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Cause:
Solution:
opw-2924276
Forward-Port-Of: #97181