[FW][FIX] account_edi_ubl_cii: Don't attach edi document to on confirm #98583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce:
- Install Netherlands localization module
- In the `Customer Invoice` journal, activate `NLCIUS (Netherlands)`
as Electronic Invoicing
- Create a new invoice and confirm
Issue:
XML generated and available as attachment and if we click on
`Send & print`, a second one is added to attachments.
Cause:
If it's not a factur-x or e-fff edi documents, we will generate the
XML file add it as attachment on confirm.
Solution:
Don't add as attachment of the invoice when confirming invoice if
code is `nlcius_1` (like for factur-x and e-fff edi documents),
only when generating invoice PDF (`Sent & Print`).
opw-2751148
X-original-commit: 6c090da
|
This PR targets saas-15.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
This was referenced Aug 22, 2022
robodoo
pushed a commit
that referenced
this pull request
Aug 23, 2022
Steps to reproduce:
- Install Netherlands localization module
- In the `Customer Invoice` journal, activate `NLCIUS (Netherlands)`
as Electronic Invoicing
- Create a new invoice and confirm
Issue:
XML generated and available as attachment and if we click on
`Send & print`, a second one is added to attachments.
Cause:
If it's not a factur-x or e-fff edi documents, we will generate the
XML file add it as attachment on confirm.
Solution:
Don't add as attachment of the invoice when confirming invoice if
code is `nlcius_1` (like for factur-x and e-fff edi documents),
only when generating invoice PDF (`Sent & Print`).
opw-2751148
closes #98583
X-original-commit: 6c090da
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>
fw-bot
deleted the
saas-15.4-14.0-opw-2751148-account_edi_ubl_cii-fix-bon-i0p--fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Customer Invoicejournal, activateNLCIUS (Netherlands)as Electronic Invoicing
Issue:
XML generated and available as attachment and if we click on
Send & print, a second one is added to attachments.Cause:
If it's not a factur-x or e-fff edi documents, we will generate the
XML file add it as attachment on confirm.
Solution:
Don't add as attachment of the invoice when confirming invoice if
code is
nlcius_1(like for factur-x and e-fff edi documents),only when generating invoice PDF (
Sent & Print).opw-2751148
Forward-Port-Of: #98516
Forward-Port-Of: #98417