[FW][FIX] account_edi: "process now" throws when already processing #98614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Process now" button throws a UserError if doc is already processing => but only thrown if parameter with_commit=False PR odoo#87266 changed with_commit default value for test purposes => accidentally prevented the UserError from popping up This PR restores with_commit default value for button action => User now gets the expected UserError pop up X-original-commit: 451fbfb
|
This PR targets saas-15.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Aug 23, 2022
The "Process now" button throws a UserError if doc is already processing => but only thrown if parameter with_commit=False PR #87266 changed with_commit default value for test purposes => accidentally prevented the UserError from popping up This PR restores with_commit default value for button action => User now gets the expected UserError pop up closes #98614 X-original-commit: 451fbfb Signed-off-by: Josse Colpaert <jco@odoo.com> Signed-off-by: Stanislas Gueniffey (stgu) <stgu@odoo.com>
fw-bot
deleted the
saas-15.4-15.0-account_edi_button_process_fix-stgu-z2Ec-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Process now" button throws a UserError if doc is already processing
PR #87266 changed with_commit default for test purposes
This PR restores with_commit default value for button action
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #97835