Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] website_sale_delivery: keep delivery method when using giftcards #98616

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Aug 22, 2022

Current behavior:
If you have atleast 2 delivery methods available on the website,
and try to pay with a giftcard the selected delivery method will
always switch to the first method of the list.

Steps to reproduce:

  • Activate giftcards for website
  • Publish atleast 2 delivery methods (one free and one not free)
  • Go on the website shop, and add product to the cart
  • Process checkout and select the not free delivery method
  • Pay with giftcard
  • The delivery price is 0 so the delivery method has been
    modified

opw-2883592

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #98579
Forward-Port-Of: #96855

Current behavior:
If you have atleast 2 delivery methods available on the website,
and try to pay with a giftcard the selected delivery method will
always switch to the partner preferred delivery method.

Steps to reproduce:
- Activate giftcards for website
- Set a preferred shipping method for partner A
- Make sure the preferred shipping method is website published
- Publish atleast one other shipping method for the website
- Go on the website shop, and add product to the cart
- Process checkout and select any shipping method that is not
  the preferred shipping method of partner A
- Pay with giftcard
- The selected delivery method switch back to the preferred method
  of partner A

opw-2883592

X-original-commit: b356091
@robodoo
Copy link
Contributor

robodoo commented Aug 22, 2022

@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 22, 2022

This PR targets saas-15.4 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Aug 22, 2022
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Aug 22, 2022
robodoo pushed a commit that referenced this pull request Aug 23, 2022
Current behavior:
If you have atleast 2 delivery methods available on the website,
and try to pay with a giftcard the selected delivery method will
always switch to the partner preferred delivery method.

Steps to reproduce:
- Activate giftcards for website
- Set a preferred shipping method for partner A
- Make sure the preferred shipping method is website published
- Publish atleast one other shipping method for the website
- Go on the website shop, and add product to the cart
- Process checkout and select any shipping method that is not
  the preferred shipping method of partner A
- Pay with giftcard
- The selected delivery method switch back to the preferred method
  of partner A

opw-2883592

closes #98616

X-original-commit: b356091
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>
@robodoo robodoo temporarily deployed to merge August 23, 2022 08:52 Inactive
@robodoo robodoo closed this Aug 23, 2022
@fw-bot fw-bot deleted the saas-15.4-15.0-opw-2883592-1-delivery_method_switch_giftcards-roen-tRJL-fw branch September 6, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants