[IMP] core: allow skipping field recomputitation on installation #99571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yelizariev
force-pushed
the
master-skip-recomputation-on-installation-IEL
branch
from
e006591
to
f969ccf
Compare
yelizariev
force-pushed
the
master-skip-recomputation-on-installation-IEL
branch
5 times, most recently
from
e14bed9
to
0ade5e4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
yelizariev
force-pushed
the
master-skip-recomputation-on-installation-IEL
branch
2 times, most recently
from
4589877
to
6c930a6
Compare
yelizariev
force-pushed
the
master-skip-recomputation-on-installation-IEL
branch
2 times, most recently
from
cdfcddd
to
d355674
Compare
C3POdoo
requested review from
a team and
jbw-odoo
and removed request for
a team
yelizariev
force-pushed
the
master-skip-recomputation-on-installation-IEL
branch
2 times, most recently
from
ee58a9c
to
69b66da
Compare
|
Previously discussed in #69132 |
|
@rco-odoo
|
yelizariev
force-pushed
the
master-skip-recomputation-on-installation-IEL
branch
from
69b66da
to
d35784a
Compare
yelizariev
force-pushed
the
master-skip-recomputation-on-installation-IEL
branch
from
d35784a
to
efa01ac
Compare
yelizariev
force-pushed
the
master-skip-recomputation-on-installation-IEL
branch
from
efa01ac
to
e71e31a
Compare
When a module adds new computated field, it may take significant time to make initial computation. Before this commit, the only way to avoid this was using `_auto_init`. Example: https://github.com/odoo/odoo/blob/ca0d8978b6585fe4f96100df56b8a7346468dc6c/addons/l10n_latam_invoice_document/models/account_move.py#L42-L44 https://github.com/odoo/enterprise/blob/46812d9abb3eb6e2b5ac565b4817548317c4a354/l10n_mx_edi_extended/models/account_move.py#L79-L82 But such method requires creating columns manually. This commit allows using `_init_column` method instead by adding return value ``initialized`` Also, make some cleanup in odoo/fields.py and move code "optimization for computing simple related fields like 'foo_id.bar'" to new method `initialize` Also, some fields don't need neither `_init_column` nor `_auto_init` if they are simple related fields
yelizariev
force-pushed
the
master-skip-recomputation-on-installation-IEL
branch
from
e71e31a
to
f55d6e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a module adds new computated field, it may take significant time to make
initial computation. Before this commit, the only way to avoid this was using
_auto_init. Example:odoo/addons/l10n_latam_invoice_document/models/account_move.py
Lines 42 to 44 in ca0d897
https://github.com/odoo/enterprise/blob/46812d9abb3eb6e2b5ac565b4817548317c4a354/l10n_mx_edi_extended/models/account_move.py#L79-L82
But such method requires creating columns manually.
This commit allows using
_init_columnmethod instead by adding return valueinitializedAlso, make some cleanup in odoo/fields.py and move code
"optimization for computing simple related fields like 'foo_id.bar'" to new method
initializeDescription of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr