Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Page has JavaScript errors! #1436

Closed
aadrian opened this issue May 16, 2023 · 5 comments · Fixed by #1437
Closed

Main Page has JavaScript errors! #1436

aadrian opened this issue May 16, 2023 · 5 comments · Fixed by #1437
Assignees
Labels
bug Something isn't working playground

Comments

@aadrian
Copy link

aadrian commented May 16, 2023

Hi,

The Main Page https://odoo.github.io/owl/ seems to have JS Errors right now:

owl_mainpage_js_error

Thank you.

@AniketNS
Copy link

Hey @aadrian, assign this issue to me. I'd like to work on this issue.

@aadrian
Copy link
Author

aadrian commented May 16, 2023

@AniketNS only team members can assign issues in the current project configuration.

Also there seem to be quite a big amount of un-merged PRs https://github.com/odoo/owl/pulls

@AniketNS
Copy link

Yup, Looking like no one is here working on this project.

@sdegueldre
Copy link
Contributor

I'm working on this and have a fix that will be pushed soon.

@sdegueldre sdegueldre self-assigned this May 16, 2023
@sdegueldre sdegueldre added bug Something isn't working playground labels May 16, 2023
sdegueldre added a commit that referenced this issue May 16, 2023
When refactoring the playground to use es-modules, a script that loads
owl as a non-module was forgotten in the head of the page and causes an
error in the console, as the script is not declared as type="module"
despite being an es-module. This script is also useless as owl is loaded
by being imported by the counter component in the page.

The importmap has also been moved to the head because of a bug in
firefox where importmaps can fail to be taken into account if they are
after a script that is not of type="module", see:
https://bugzilla.mozilla.org/show_bug.cgi?id=1833371

Closes #1436
sdegueldre added a commit that referenced this issue May 16, 2023
When refactoring the playground to use es-modules, a script that loads
owl as a non-module was forgotten in the head of the page and causes an
error in the console, as the script is not declared as type="module"
despite being an es-module. This script is also useless as owl is loaded
by being imported by the counter component in the page.

The importmap has also been moved to the head because of a bug in
firefox where importmaps can fail to be taken into account if they are
after a script that is not of type="module", see:
https://bugzilla.mozilla.org/show_bug.cgi?id=1833371

Closes #1436
@sdegueldre
Copy link
Contributor

Also there seem to be quite a big amount of un-merged PRs https://github.com/odoo/owl/pulls

most of the unmerged PRs are either very minor, or outdated proof of concepts that should be closed. If there are some PRs that you think need to be merged and deserve attention feel free to ping me on them and I'll take a look.

ged-odoo pushed a commit that referenced this issue May 16, 2023
When refactoring the playground to use es-modules, a script that loads
owl as a non-module was forgotten in the head of the page and causes an
error in the console, as the script is not declared as type="module"
despite being an es-module. This script is also useless as owl is loaded
by being imported by the counter component in the page.

The importmap has also been moved to the head because of a bug in
firefox where importmaps can fail to be taken into account if they are
after a script that is not of type="module", see:
https://bugzilla.mozilla.org/show_bug.cgi?id=1833371

Closes #1436
phil-form pushed a commit to phil-form/owl that referenced this issue Nov 7, 2023
When refactoring the playground to use es-modules, a script that loads
owl as a non-module was forgotten in the head of the page and causes an
error in the console, as the script is not declared as type="module"
despite being an es-module. This script is also useless as owl is loaded
by being imported by the counter component in the page.

The importmap has also been moved to the head because of a bug in
firefox where importmaps can fail to be taken into account if they are
after a script that is not of type="module", see:
https://bugzilla.mozilla.org/show_bug.cgi?id=1833371

Closes odoo#1436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working playground
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants