Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected different behaviour for t-out and t-esc when used on a component tag #1483

Closed
BastienFafchamps opened this issue Jul 19, 2023 · 0 comments · Fixed by #1484
Closed

Unexpected different behaviour for t-out and t-esc when used on a component tag #1483

BastienFafchamps opened this issue Jul 19, 2023 · 0 comments · Fixed by #1484

Comments

@BastienFafchamps
Copy link
Contributor

Using a t-esc on a component tag does add the text to the component default slot, while using a t-out replaces the whole component tag by a text node. I think the behaviour should be the same for both.

<Comp t-esc="'foo'"/> => <div class="my-comp">foo</div>

<Comp t-out="'foo'"/> =>  "foo"
ged-odoo added a commit that referenced this issue Jul 19, 2023
@ged-odoo
[FIX] compiler: allow t-out on component tag
8272643 
Before this commit, the template parser would allow using t-esc on a
component tag (<MyComponent t-esc="expr"/>) but would incorrectly ignore
the component when parsing a t-out: <MyComponent t-out="expr"/> would be
parsed as <t t-out="expr"/>

This commit solves the issue, and also, moves the `t-out` parsing code
next to `t-esc` so they have the same priority relatively to other
directives.

closes #1483
@ged-odoo ged-odoo mentioned this issue Jul 19, 2023
Merged
ged-odoo added a commit that referenced this issue Jul 19, 2023
@ged-odoo
[FIX] compiler: allow t-out on component tag
4d21ff2 
Before this commit, the template parser would allow using t-esc on a
component tag (<MyComponent t-esc="expr"/>) but would incorrectly ignore
the component when parsing a t-out: <MyComponent t-out="expr"/> would be
parsed as <t t-out="expr"/>

This commit solves the issue, and also, moves the `t-out` parsing code
next to `t-esc` so they have the same priority relatively to other
directives.

closes #1483
sdegueldre pushed a commit that referenced this issue Jul 19, 2023
@ged-odoo @sdegueldre
[FIX] compiler: allow t-out on component tag
2e07799 
Before this commit, the template parser would allow using t-esc on a
component tag (<MyComponent t-esc="expr"/>) but would incorrectly ignore
the component when parsing a t-out: <MyComponent t-out="expr"/> would be
parsed as <t t-out="expr"/>

This commit solves the issue, and also, moves the `t-out` parsing code
next to `t-esc` so they have the same priority relatively to other
directives.

closes #1483
phil-form pushed a commit to phil-form/owl that referenced this issue Nov 7, 2023
@ged-odoo @phil-form
[FIX] compiler: allow t-out on component tag
aabd014 
Before this commit, the template parser would allow using t-esc on a
component tag (<MyComponent t-esc="expr"/>) but would incorrectly ignore
the component when parsing a t-out: <MyComponent t-out="expr"/> would be
parsed as <t t-out="expr"/>

This commit solves the issue, and also, moves the `t-out` parsing code
next to `t-esc` so they have the same priority relatively to other
directives.

closes odoo#1483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] compiler: allow t-out on component tag odoo/owl
1 participant
@BastienFafchamps