Master doc ged #1137
Open
Master doc ged #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ged-odoo
force-pushed
the
master-doc-ged
branch
2 times, most recently
from
1a5da0c
to
daa58d4
Compare
ged-odoo
force-pushed
the
master-doc-ged
branch
from
daa58d4
to
a5c07d9
Compare
poma-odoo
reviewed
Nov 18, 2022
| ## Reactivity | ||
|
|
||
| With the reactivity system, each value created with the `useState` or the `reactive` | ||
| function is a proxy that allows Owl to trask which keys/values have been read |
There was a problem hiding this comment.
Suggested change
| function is a proxy that allows Owl to trask which keys/values have been read | |
| function is a proxy that allows Owl to track which keys/values have been read |
Comment on lines
+83
to
+84
| that some => may miss | ||
| rendering |
There was a problem hiding this comment.
Suggested change
| that some => may miss | |
| rendering | |
| that some may miss rendering. | |
| ( Don't `let a=toRaw(r); f(a);` do `f(toRaw(r));` ) |
| ``` | ||
|
|
||
| ```js | ||
| // bad => will cause extra rendering, possibly corrupt |
| }); | ||
| ``` | ||
|
|
||
| other note: minimize async stuff |
There was a problem hiding this comment.
Looks like an orphan in this context
Comment on lines
+150
to
+155
| A | ||
|
|
||
| / \ | ||
| B C | ||
| / | \ | \ | ||
| D E F G H |
There was a problem hiding this comment.
Suggested change
| A | |
| / \ | |
| B C | |
| / | \ | \ | |
| D E F G H | |
| ```mermaid | |
| graph TD | |
| A-->B | |
| A-->C | |
| B-->D | |
| B-->E | |
| B-->F | |
| C-->G | |
| C-->H | |
| ``` |
| Notes: | ||
|
|
||
| - model could be created elsewhere, in a service, in the start code, ... | ||
| - one may want to mark some internal stuff as 'raw'... |
There was a problem hiding this comment.
Suggested change
| - one may want to mark some internal stuff as 'raw'... | |
| - one may want to mark some internal stuff as 'raw', when reactivity is not necessary, to save the resources. |
|
|
||
| - model could be created elsewhere, in a service, in the start code, ... | ||
| - one may want to mark some internal stuff as 'raw'... | ||
| - if created elsewhere, it should probably be done with `reactive` |
There was a problem hiding this comment.
Suggested change
| - if created elsewhere, it should probably be done with `reactive` | |
| - if created elsewhere, it should probably be done with `reactive` instead of `useState`, e.g. `obj.model = reactive(new MyModel)` |
| - model could be created elsewhere, in a service, in the start code, ... | ||
| - one may want to mark some internal stuff as 'raw'... | ||
| - if created elsewhere, it should probably be done with `reactive` | ||
| - the call to `reactive` could be done in the model constructor directly: |
There was a problem hiding this comment.
Suggested change
| - the call to `reactive` could be done in the model constructor directly: | |
| - the call to `reactive` could be done in the model constructor directly, so there would be no need to call `reactive` on each use: |
| class MyModel { | ||
| constructor() { | ||
| ... | ||
| return reactive(this); |
There was a problem hiding this comment.
Suggested change
| return reactive(this); | |
| return reactive(this); // All instances of MyModel will be recative automatically |
Comment on lines
+310
to
+326
| - one could slightly simplify the model use with a hook: | ||
|
|
||
| ```js | ||
| function useModel() { | ||
| const env = useEnv(); | ||
| const model = env.model; | ||
| return useState(model); | ||
| } | ||
| ``` | ||
|
|
||
| This can be simply used like this in a child component: | ||
|
|
||
| ```js | ||
| setup() { | ||
| this.model = useModel(); | ||
| } | ||
| ``` |
There was a problem hiding this comment.
This is almost a duplicate of line 222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.