-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest Spring-boot >= 2.3.4 update causes SubjectArea initialization failure (reflection) #3994
Comments
I will create a PR to update the base spring components, but not spring boot. This replaces dependabots proposals |
FYI @davidradl I didn't keep a full log, but note the first failure was in subject area. I suspect a spring regression however |
when fixed, springdoc will also need updating |
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Having just tried with spring boot 2.3.5, this same error is still occuring.
I think it's going to be important we understand this in more detail -- and either report to spring, or figure out what we are doing wrong. Gradually we are going to start to get more into stick dependency/security issues if we get blocked. @bogdan-sava @davidradl Do you have any ideas on this? |
I will try again with 2.3.6, but I do think we need some investigation done in that timescale as this could be a change/bug fix going forwards |
To clarify -- this occurs when starting a server - in my case it was in the coco pharma environment, and explicitly occurred with subject area. I've not verified if it occurs with all OMASs, |
I was not able to reproduce it.
I ran it in different configurations: worked fine for me:
|
I am using
|
maybe is this related to: looks pretty similar to me |
Typical - I'd read that issue, but hadn't commented or seen the latest comment as it was originally reported earlier in the year and should have added the link. Thanks @bogdan-sava for adding the pointer. Looks promising in terms of the cause being not of our doing! |
Thanks on the jdk info @bogdan-sava I wonder if it could be java version related (possible esp as it's reflection). will do some more checks |
I mis-represented the issue - in part as I have a composite log across multiple processes. In fact the key error is
which is from the Polymer UI, not the server chassis that I incorrectly stated. |
Still cannot reproduce on my side. |
I was using java 11, though I hit the error on multiple jvms Ok thanks - I can try out the PR when ready |
I created PR , but didn't link it to this issue, as the PR should be merged anyway as tidy up dependencies (subject-area is no more part of the ui-chassis-spring). |
Thanks, I'll repeat the scenario with the new PR + updated springboot & note here. |
I can confirm your change now allows updated spring to work. without, it fails |
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Thanks @planetf1 . |
Understand, of course it would be good to understand the exact mechanics. Since we don't need subject area there currently I think we're good on the server for now. IF we think we'll take further investigation - ie if you want to investigate more - we could keep this issue open. |
When originally reported I pasted in a log of the UI chassis failing - but thought I'd seen the main server chassis fail. I couldn't reproduce, tested again, and after the removal of subject area was able to run the server chassis ok. However I didn't go back and retest the coco environment with OMASs being enabled. The PR tests at https://github.com/odpi/egeria/pull/4063/checks?check_run_id=1352190205 are now showing that with the spring update, FVTs are failing. This is because they attempt to start the egeria server chassis, which fails with this
Other OMASs have started OK, so this looks specific to Subject Area So @bogdan_sava you were right to be concerned -- removing it from the UI fixed the issue there, but it fails in another context too. I still don't know if this is a spring issue, or a problem with subject area, although only that component is affected |
Indeed |
keep investigate it |
Looks like this may be fixed in 2.3.6 - not tested yet. spring-projects/spring-boot#23821 target 2.6 |
2.4 did fix it, however it broke another aspect - the netflix azuul capability resulting in a broken UI - as identified in #4263 Leaving this open in anticipation of an update to the required dependencies during December which we can action in January |
We have issues open to address removal of zuul & updating of spring dependencies, so closing this one |
Using spring-boot 2.3.4 & spring 5.3.0 egeria will fail to start with many errors relating to 'java.lang.IllegalStateException: zip file closed' when trying to do reflection on the subject area package
spring-boot 2.3.4 introduces this problem to egeria.
I propose to defer further investigation until the next spring-boot release - there seem to have been a history of issues in this area with spring at various points in time.
The text was updated successfully, but these errors were encountered: