Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate HTTP headers - Coco Pharma example #6977

Merged

Conversation

MihaiIliescu
Copy link
Contributor

Description

This change represents an example on how HTTP headers can be used for authorisation within a connector. This is a follow up to #6793 and #6851.

Testing

Functional testing

Signed-off-by: Iliescu Cristian-Mihai <cristianmihaiiliescu@gmail.com>
Signed-off-by: Iliescu Cristian-Mihai <cristianmihaiiliescu@gmail.com>
Signed-off-by: Iliescu Cristian-Mihai <cristianmihaiiliescu@gmail.com>
@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Oct 3, 2022

⚠️ 107 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

Signed-off-by: Iliescu Cristian-Mihai <cristianmihaiiliescu@gmail.com>
Signed-off-by: Iliescu Cristian-Mihai <cristianmihaiiliescu@gmail.com>
@planetf1
Copy link
Member

planetf1 commented Jan 3, 2023

The open metadata security samples project includes 2 connectors currently, both based on coco pharma

  • platform
  • server

This PR proposes a http security connector, and in that it follows the existing sample.

As such I don't have any issue with merging this in, but it does bring up two questions

a) As the three connectors are seperately identfied/configured, do we want them in seperately deployable jars - this is how we usually do things - which would mean 3 artifacts. However we don't have to do this, ie if closely related
b) more of our samples are moving to repositories outside core egeria, since they are optional. Should we be thinking of that here?

Signed-off-by: Iliescu Cristian-Mihai <cristianmihaiiliescu@gmail.com>
@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Jan 23, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/odpi/egeria/6977.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/odpi/egeria/6977.diff | git apply

Once you're satisfied commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

Signed-off-by: Iliescu Cristian-Mihai <cristianmihaiiliescu@gmail.com>
@MihaiIliescu MihaiIliescu marked this pull request as ready for review January 25, 2023 11:33
Copy link
Contributor

@lpalashevski lpalashevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. See minor comment about adding the example payload in the class javadoc.

Signed-off-by: Iliescu Cristian-Mihai <cristianmihaiiliescu@gmail.com>
Signed-off-by: Iliescu Cristian-Mihai <cristianmihaiiliescu@gmail.com>
@lpalashevski
Copy link
Contributor

lpalashevski commented Jan 25, 2023

The open metadata security samples project includes 2 connectors currently, both based on coco pharma

* platform

* server

This PR proposes a http security connector, and in that it follows the existing sample.

As such I don't have any issue with merging this in, but it does bring up two questions

a) As the three connectors are seperately identfied/configured, do we want them in seperately deployable jars - this is how we usually do things - which would mean 3 artifacts. However we don't have to do this, ie if closely related
b) more of our samples are moving to repositories outside core egeria, since they are optional. Should we be thinking of that here?

@planetf1

I think we should keep the samples under single deployable jar (as is now).

We can move the security connector samples to new repository if we decide in future but at this point it is just extra work and no value (The current samples are static, everything is hard coded. They do not provide value outside of the labs/tutorials)

We should revisit the idea in the next iteration when we introduce connectors that integrate with LDAP and/or provide new services such as token based access control - parts discussed on the last workshop.

@lpalashevski lpalashevski merged commit b8c0f65 into odpi:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants