Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade snakeyaml to 2.0 in gradle bom #7510

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Conversation

ilovechai
Copy link
Contributor

@ilovechai ilovechai commented Mar 9, 2023

Description

Upgrade snakeyaml 1.30 -> 2.0
Seems like dependabot bumped the version in pom.xml https://github.com/odpi/egeria/blob/main/pom.xml#L217 but not in build.gradle

Related Issue(s)

#7509

Testing

gradle open-metadata-implementation:server-chassis:server-chassis-spring:dependencyInsight --configuration compileClassPath --dependency snakeyaml

Task :open-metadata-implementation:server-chassis:server-chassis-spring:dependencyInsight

  • Dependency insight before change
org.yaml:snakeyaml:1.33
\--- compileClasspath

org.yaml:snakeyaml:1.30 -> 1.33
\--- org.springframework.boot:spring-boot-starter:2.7.9
     +--- org.springframework.boot:spring-boot-starter-actuator:2.7.9
     |    \--- compileClasspath (requested org.springframework.boot:spring-boot-starter-actuator)
     +--- org.springframework.boot:spring-boot-starter-web:2.7.9
     |    \--- compileClasspath (requested org.springframework.boot:spring-boot-starter-web)
     +--- org.springframework.boot:spring-boot-starter-validation:2.7.9
     |    \--- compileClasspath (requested org.springframework.boot:spring-boot-starter-validation)
     \--- org.springframework.boot:spring-boot-starter-json:2.7.9
          \--- org.springframework.boot:spring-boot-starter-web:2.7.9 (*)

BUILD SUCCESSFUL in 2s
1 actionable task: 1 executed
  • Dependency insight after change
org.yaml:snakeyaml:2.0
\--- compileClasspath

org.yaml:snakeyaml:1.30 -> 2.0
\--- org.springframework.boot:spring-boot-starter:2.7.9
     +--- org.springframework.boot:spring-boot-starter-actuator:2.7.9
     |    \--- compileClasspath (requested org.springframework.boot:spring-boot-starter-actuator)
     +--- org.springframework.boot:spring-boot-starter-web:2.7.9
     |    \--- compileClasspath (requested org.springframework.boot:spring-boot-starter-web)
     +--- org.springframework.boot:spring-boot-starter-validation:2.7.9
     |    \--- compileClasspath (requested org.springframework.boot:spring-boot-starter-validation)
     \--- org.springframework.boot:spring-boot-starter-json:2.7.9
          \--- org.springframework.boot:spring-boot-starter-web:2.7.9 (*)

BUILD SUCCESSFUL in 2s
1 actionable task: 1 executed

Release Notes & Documentation

N/A

Additional notes

cc: @planetf1

Signed-off-by: Krishna Sheth <krishna.sheth@ibm.com>
@ilovechai ilovechai requested a review from planetf1 as a code owner March 9, 2023 23:25
@planetf1
Copy link
Member

The snakeyaml update previously caused issues with Spring .
We currently have PRs open to merge a Spring 6 update -- at that time we plan to retry the snakeyaml update.
Hopefully that will be in a matter of days. #7506 or the other PR referenced within
There are also some other updates/reviews of versions to be done once that big change is in.

Let's leave this PR open & hopefully we can get it in soon

@planetf1 planetf1 merged commit 005849d into odpi:main Mar 13, 2023
@ilovechai ilovechai deleted the krishna-7509/1 branch March 13, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants