Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7684 Add self-build Dockerfile #7685

Merged
merged 3 commits into from
May 23, 2023
Merged

#7684 Add self-build Dockerfile #7685

merged 3 commits into from
May 23, 2023

Conversation

planetf1
Copy link
Member

@planetf1 planetf1 commented May 17, 2023

Description

provides a new Dockerfile (in addition to existing) which will

  • Download/extract source from github
  • Build egeria using gradle
  • Allow egeria to be launched as before (end result is identical)
  • Adds docs on build & runtime parameters

A dockerfile can be built directly using only this new single Dockerfile.selfbuild - and there is no requirement to build egeria in advance, nor copy files around. This may make it easier for developers, it can be built directly on dockerhub, and easily fit into a ci/cd process

Of course organization processes will vary, so it ultimately just forms another example of how one could build an image

Fixes #7684

Related Issue(s)

Testing

  • Built and run with docker build -t planetf1/egeria:selfbuild1 -f ./Dockerfile.selfbuild . && docker run docker.io/planetf1/egeria:selfbuild1
  • Not tested all optional parameters

Release Notes & Documentation

If we think it's useful, we should add content to the release notes once we've had a chance to review/try it out

Additional notes

cc: @dwolfson @lpalashevski @mandy-chessell

In future may want to consider

  • Additional configurability ie
    • Adding or removing components
    • Adding in external connectors (currently we do this only in the k8s charts)

We might also be able to build directly from a git url - see https://docs.docker.com/engine/reference/commandline/build/
However I could not get this working with rancher desktop. Also our dockerfile is deep in the directory tree, and has an alternative name. May need refactoring

I offer it as an example, a starting point for further ideas

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
@planetf1 planetf1 enabled auto-merge May 23, 2023 11:48
@planetf1 planetf1 merged commit d362cbb into odpi:main May 23, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add self-build Dockerfile for egeria
1 participant