Feature/native token #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zie1ony
requested changes
Oct 13, 2022
| }, | ||
| syn::ReturnType::Type(_, _) => quote! { | ||
| use odra::types::CLTyped; | ||
| #args | ||
| odra::call_contract(&self.address, #entrypoint_name, &args) | ||
| odra::call_contract(&self.address, #entrypoint_name, &args, self.attached_value) |
There was a problem hiding this comment.
Shouldn't you set self.attached_value to None after those call_contract calls?
There was a problem hiding this comment.
I guess I should, good catch.
There was a problem hiding this comment.
But the thing is, it implies all the functions must be mutable. If so, a user has to define a contract ref as mutable but is not too intuitive.
* move balances to storage * revert balances along with state * remove Account struct * add Balance struct * add Callstack and CallstackElement * Remove Contract struct
zie1ony
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #36