Allow custom port specification for replay #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This approach allows the replay to run on the specified port but the Link header for mementos does not use this value. It instead uses the value in the ipwb config. However, we might not want to overwrite the port in the config for this one-off specification. Let's see which way @ibnesayeed prefers in #760 before we move forward in remedying the issue.
ibnesayeed
reviewed
Apr 5, 2022
ipwb/util.py
Outdated
| @@ -269,6 +269,12 @@ def get_ipwb_replay_config(ipfs_json=None): | |||
| return None | |||
|
|
|||
|
|
|||
| def set_ipwb_replay_config_portonly(port): | |||
| ipfs_json = read_ipfs_config() | |||
| ipfs_json['Ipwb']['Replay']['Port'] = port | |||
There was a problem hiding this comment.
Are we sure that ipfs_json['Ipwb']['Replay'] will be populated already even on the first run when there is no config file in place? If not, then this might throw an exception.
There was a problem hiding this comment.
Good catch! It does throw an exception in this instance. I will update the PR.
|
@ibnesayeed I redid some of the logic for retaining the port value and made sure to check if ipwb values have been set prior to trying to write to them. Please review. |
|
@machawk1 perhaps it will also be a good idea to allow specifying custom host along the same lines, but that can happen in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...with the value retained in the config file per #760
Closes #760