Merg Releases/0.1.0 into dev #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module docstring, the main function with its docstring and the imports necessary to declare all of this are put under version control. This helps to differentiate the actual code moved from other modules from the surrounding code wrapping the moved code into a function and documenting it.
The code only got moved, `self.series` got replaced with `timeseries` and some indentation got changed according to the new layout. Nothing else should have changed.
First, using parenthesis instead of square brackets means instantiation and is wrong. Second, specifying a `tuple` type should be done via `typing.Tuple` and last but not least, the return type annotation via `->` was missing.
The code previously worked on the `series` dictionary as a whole, but the type annotation and the documentation hinted at the fact that `deduplicate` only works on one list, i.e. on dictionary value, at a time. Doing so makes the code more compact and doesn't complicate the `deduplicate` call too much.
It used a very general type variable, where the type it expects is actually quite specific. In order to fix that, this commit adds an alias for this specific type and uses that instead of the type variable.
The multiples are themselves stored in lists containing consecutive values which are deemed equal.
These values are compressed to pairs of the slice they cover and the value they represent.
We have to go in reverse because replacing a covered slice with a single value shortens the sequence, invalidating the indices of the other slices. That's why we have to start with the last slice.
Not being able to compress all duplicates into one value means that some values are beyond the desired margins of error, in which case raising an error is probably the right choice.
The final release of the open_FRED weather data has been moved to the "climate" schema, so that's where we should look for it by default from now on.
Using `None` worked with the "oedialect" but didn't work when connecting to the PostgreSQL database via "psycopg2". Also, using `True` makes more sense because a filter which is always `True` doesn't filter anything, which is what we want here.
This feature does not work because it causes a circular import. We will try to fix it in another issue.
…rc-directory-ci Revise the feedinlib structure following the structure of the other oemof packages
p-snft
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both branches (dev and 0.1.0) have nothing to do with v0.0.12 and are not API stable. So we could go on with the
devbranch to avoid confusion.I do not add any additional code in this PR. I would ignore the decreasing coverage and open an extra PR to increase the test coverage.