Update setup.py #76
Merged
Update setup.py #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added open_FRED-cli to install_requires list
|
Thanks for your contribution. The reason why open_FRED-cli is added to the requirements should be named in the commit/ merge message, would you please edit your comment above so that this will be done? |
|
Hello again, I found a missing comma in the setup.py file (after "open-FRED-cli"): Line 90 in c89e845 Could you please correct this? Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open_FRED-cli is used but not named in setup.py as a requirement to be installed during installation of feedinlib:
feedinlib/src/feedinlib/open_FRED.py
Line 9 in 773cde0
therefore I added open_FRED-cli to install_requires list