Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong equation in documentation #565

Closed
uvchik opened this issue Feb 7, 2019 · 2 comments
Closed

Wrong equation in documentation #565

uvchik opened this issue Feb 7, 2019 · 2 comments
Assignees
@p-snft @jnnr @FranziPl
Labels
beginner bug documentation
Projects
Release of v0.3.0
Milestone
v0.3.0

Comments

@uvchik
Copy link
Member

uvchik commented Feb 7, 2019 •
edited

In the second equation the P_el should be greater equal not lower equal than the right hand side.

https://oemof.readthedocs.io/en/latest/api/oemof.solph.html#oemof.solph.components.ExtractionTurbineCHPBlock

In this context we could check the rest :-)

@oemof/oemof-assistants Does anybody wants to help?
@uvchik uvchik added this to the v0.3.0 milestone Feb 7, 2019
@uvchik uvchik added this to To do in Release of v0.3.0 via automation Feb 7, 2019
@jnnr jnnr assigned jnnr and FranziPl Feb 7, 2019
@p-snft p-snft self-assigned this Feb 8, 2019
@uvchik uvchik mentioned this issue Feb 12, 2019
Closed
@uvchik uvchik added the bug label Feb 12, 2019
@ajimenezUCLA
Copy link
Contributor

I would like to be assigned this, I need to figure out how to use docstring though.

ajimenezUCLA added a commit to ajimenezUCLA/oemof that referenced this issue Feb 18, 2019
@ajimenezUCLA
Issue oemof#565 and Issue oemof#566 fixed
886600d
@ajimenezUCLA ajimenezUCLA mentioned this issue Feb 18, 2019
Merged
@p-snft p-snft mentioned this issue Feb 18, 2019
Merged
p-snft added a commit that referenced this issue Feb 18, 2019
@p-snft
Merge pull request #568 from ajimenezUCLA/dev
c2b9f4f 
Issue #565 and Issue #566 fixed
@p-snft
Copy link
Member

p-snft commented Feb 26, 2019 •
edited

As nobody joins the search for errors in equations: It would be useful to perform the check based on the updated docstring template (see #565). When the equations are rewritten to a more readable form, it is easy to check them right away.

Thus, I am going to perform the pull request #569.

@p-snft p-snft closed this as completed in 781608d Feb 26, 2019
Release of v0.3.0 automation moved this from To do to Done Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p-snft p-snft

@jnnr jnnr

@FranziPl FranziPl

Labels
beginner bug documentation
Projects
No open projects
Release of v0.3.0
  
Done
Milestone
v0.3.0
Development

No branches or pull requests
5 participants
@uvchik @p-snft @ajimenezUCLA @jnnr @FranziPl