Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple outputs for offsetConverter #996

Closed
drmattimoli opened this issue Oct 13, 2023 · 1 comment
Closed

Multiple outputs for offsetConverter #996

drmattimoli opened this issue Oct 13, 2023 · 1 comment

Comments

@drmattimoli
Copy link

Considering the Converter class implementation, is there a reason for the offsetConverter to not be able to provide multiple outputs? This could be very useful, e.g. when augmenting an existing energysystem implementation with partload efficiency.

@p-snft
Copy link
Member

p-snft commented Oct 18, 2023

Hi @drmattimoli, I really see the point. Here is a bit of background:

The Converter relates all inputs with all outputs. This is only possible because the relations are linear without an offset. In principle, it was possible to have one input but multiple outputs for the OffsetConverter. So, the Converter can do N:M connections with arbitrary N, M. The OffsetConverter could do 1:M, if we implemented that. However, you achieve exactly the same by using multiple OffsetConverters sharing the same Converter as their source. For M:1 conversion, you will always have do it that way. So, for the sake of consistence, OffsetConverter can only do 1:1.

@p-snft p-snft closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants