-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/restructure network #791
Conversation
Known issues: A lot of things still need to be adjusted. LP files for the tests are among them.
I am currently wondering if components, buses and flows should be available in solph directly or if categories should be provided. For example, do you Little update: Currently, I allow both. Experimental stuff has to be imported from the specific submodule. |
"Modules should explicitly declare the names in their public API using the __all__ attribute." https://www.python.org/dev/peps/pep-0008/#public-and-internal-interfaces
Unitl this commit only PR into dev or master trigger the workflow. Now all PR will trigger the workflow.
This file should not be there, it's not part of the API.
There is now InvestmentFlow and NonConvexFlow. The latter takes all argments that were previously hidden in the NonConvex object. The InvestmentFlow currently only is a thin wrapper without any logic.
I am not sure about the API of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it looks fine, even though I may have missed something due to the high number of changes. But as it is not a merge into a stable branch we may have the chance to bring small issues in line, if there are any 😄
Puts a clean structure to the submodules, i.e. components and blocks are now located next to each other (implements #588).
Summary:
buses
,components
, andflows
.__all__
)Flow
,InvestmentFlow
, andNonConvexFlow
experimental
(replaces "custom")Tasks:
NonConvexFlow
andInvestmentFlow
)