Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi period investment #108

Merged
merged 21 commits into from Jul 18, 2023
Merged

Multi period investment #108

merged 21 commits into from Jul 18, 2023

Conversation

nailend
Copy link
Collaborator

@nailend nailend commented Jul 4, 2023 •
edited

Fix #106
Components work with multi-period approach. Yet missing, is a rework of the read_datapackage function and a way trigger the multi period opt, which will be addressed in another issue.

  • Added new lifetime parameter for expandable facades
  • Added new age parameter for expandable facades
  • Added new fixed_costs parameter for expandable facades
  • Added constraint test for multi-period approach
  • Added generated LP-files
  • Vaguely checked LP-files
  • compared results investment scenario ( v.0.3.0 to current)

@nailend
Add lifetime parameter to volatile facade
43c7021 
Using the multi-period approach makes necessary
to define the lifetime parameter. This parameter
is optional, a warning is raised if it is necesarry
but not passed.
@nailend
Add lifetime to _investment()
d814e88 
Lifetime parameter is passed to investement object
if passed to the facade.
@nailend
Add lifetime parameter to specific facades
7dff350
@nailend
Fix typo
88d44f6
@nailend
Add LP files for multi-period constraint test
0b75bbd
@nailend
Add test for multi-period constraints
07e5555
@nailend nailend self-assigned this Jul 4, 2023
@nailend nailend requested a review from henhuy July 4, 2023 14:05
@henhuy
Copy link
Collaborator

henhuy commented Jul 5, 2023

As I remember there was an age parameter in MP-feature - shouldn't facades provide it too?

@nailend
Copy link
Collaborator Author

nailend commented Jul 5, 2023 •
edited

As I remember there was an age parameter in MP-feature - shouldn't facades provide it too?

You are right. Sorry, I only fixed what was necessary to make it run. Will do a rework.

@nailend nailend added the enhancement New feature or request label Jul 10, 2023
@nailend nailend mentioned this pull request Jul 13, 2023
Merged
6 tasks
henhuy
henhuy requested changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@henhuy henhuy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered an error when lifetime is set but age is set to default "None" - age default should be set to zero - see failing test here: #114

src/oemof/tabular/facades/volatile.py Outdated Show resolved Hide resolved
@nailend nailend merged commit d01f97a into dev Jul 18, 2023
3 checks passed
@nailend nailend deleted the features/multi-period-investment branch July 18, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henhuy henhuy henhuy requested changes

Assignees

@nailend nailend

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Multi-period-investment from solph v.0.5.1
2 participants
@nailend @henhuy