Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rework periodic value deserialisation #154

Merged
merged 11 commits into from Jan 30, 2024

Conversation

FelixMau
Copy link
Collaborator

Description

To implement multiperiod feature multiple values might be passed for one facade. Therefore implemented array values that need to be unpacked to either act as periodical values, yearly values or as full series.

Fixes #151

Type of change

Please tick or delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Please tick or delete options that are not relevant.

  • New and adjusted code is formatted using the pre-commit hooks
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added new features/fixes to the CHANGELOG
  • I have added my name to AUTHORS

@FelixMau FelixMau linked an issue Jan 24, 2024 that may be closed by this pull request
5 tasks
@FelixMau FelixMau requested a review from nailend January 24, 2024 14:03
@FelixMau
Copy link
Collaborator Author

FelixMau commented Jan 24, 2024

Unfortunately test failes when a periodical changing value for "capacity" is added.

Deserializing for

  • storage 'capacity_cost'
  • link 'capacity_cost'
  • dispatchable 'capacity' (breaking and removed in #1be182b)
  • volatile 'marginal_cost'

@FelixMau FelixMau marked this pull request as ready for review January 30, 2024 10:08
@FelixMau
Copy link
Collaborator Author

Setting Capacity to periodical changing value failed as intended by solph when building flows.
Changing nominal values are only allowed if Investment is set.

Therefore added capacity periodical values to storage (since it is Investment object)


Note: Improvment in _flow Code style using else instead of 'pre setting' values could be improved. Throwing error might also be useful sometime

Copy link
Collaborator

@nailend nailend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks a lot

setup.py Outdated Show resolved Hide resolved
src/oemof/tabular/datapackage/reading.py Outdated Show resolved Hide resolved
src/oemof/tabular/datapackage/reading.py Show resolved Hide resolved
@FelixMau FelixMau force-pushed the feature/rework-periodic-value-deserialisation branch from 3865a24 to 65ae4e7 Compare January 30, 2024 13:25
@FelixMau FelixMau merged commit a66b90e into dev Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework periodic value deserialisation
2 participants