Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to oemof.solph 0.5.2dev1 #157

Merged
merged 5 commits into from Feb 7, 2024
Merged

Conversation

FelixMau
Copy link
Collaborator

@FelixMau FelixMau commented Feb 7, 2024

Description

Upgrade to oemof.solph 0.5.2dev1. Therefore Adjustments in LP files are necessary since end of life cost calculation changed.

Breaks LP file test if run with older solph version.

Fixes #155

Type of change

Please tick or delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Please tick or delete options that are not relevant.

  • New and adjusted code is formatted using the pre-commit hooks
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • If new packages are needed, I added them the setup.py
  • I have added my name to AUTHORS

@FelixMau FelixMau changed the title Upgrade to oemof.solph 0.5.2dev2 Upgrade to oemof.solph 0.5.2dev1 Feb 7, 2024
Copy link
Collaborator

@nailend nailend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully trust your work! :P

@FelixMau FelixMau merged commit 859b8a5 into dev Feb 7, 2024
2 checks passed
@FelixMau FelixMau deleted the upgrade_to_oemof_solph_0_5_2dev2 branch February 7, 2024 14:42
@@ -70,7 +70,7 @@ def read(*names, **kwargs):
# "oemof.solph>=0.5.1",
# Upcomming upgrade to solph 0.5.2 postponed due to many changes necessary for implementing
# explicit arguments and upgrade to network 0.5.1
"oemof.solph==0.5.2dev2",
"oemof.solph==0.5.2dev1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn a "." was missing here... but also didnt see it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: MultiPeriodConstraint tests fail upgrading solph 0.5.2dev0 to 0.5.2dev1
2 participants