Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make facades package #92

Merged
merged 3 commits into from Feb 15, 2023
Merged

Make facades package #92

merged 3 commits into from Feb 15, 2023

Conversation

jnnr
Copy link
Member

@jnnr jnnr commented Feb 14, 2023 •
edited

Splits the facade classes into submodules and adds a subpackage "experimental".

TODO:

  • Define and document requirements for facades in experimental and for established facades.

@jnnr jnnr marked this pull request as ready for review February 14, 2023 10:38
@jnnr jnnr requested a review from srhbrnds February 14, 2023 10:38
@jnnr jnnr linked an issue Feb 14, 2023 that may be closed by this pull request
"Experimental" package for new facades is missing #46
Closed
@jnnr jnnr added this to the v0.1.0 milestone Feb 15, 2023
srhbrnds
srhbrnds approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@srhbrnds srhbrnds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! All examples and checks are running.

@jnnr jnnr merged commit cd85dc2 into dev Feb 15, 2023
@jnnr jnnr deleted the revision/facades-module branch February 15, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhbrnds srhbrnds srhbrnds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

"Experimental" package for new facades is missing
2 participants
@jnnr @srhbrnds