Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hydropowerlib to list of projects #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ludee
Copy link

@Ludee Ludee commented Feb 23, 2021

I would count the hydropowerlib as part of oemof since it is an extension of the feedinlib.

The hydropowerlib is designed to calculate feedin time series of run-of-the-river hydropower plants. The hydropowerlib is an out-take from the feedinlib (hydropower, windpower and pv) to build up a community concentrating on hydropower models.
https://github.com/hydro-python/hydropowerlib

There has not been a stable release yet.

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #91 (fc8adf1) into master (5900cda) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines            8         8           
=========================================
  Hits             8         8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5900cda...fc8adf1. Read the comment docs.

@simnh
Copy link
Member

simnh commented Feb 23, 2021

Cool idea, but what do you mean be Add to projects. As far as there are others that are the core developers? why not leave it as hydro-python? (Do you plan to re-write the code for adhering to developing guidelines?) sorry- saw that they already use our rules...

Still, do you want to move the repository? Did you talk to Jonas?

@Ludee
Copy link
Author

Ludee commented Feb 23, 2021

... what do you mean be Add to projects.

I added it to the list of "Projects in an early state" in the README.rst
For me this looks like an inventory of existing modules and packages of oemof.
While it is in an external repo, it is like the windowerlib.

@p-snft
Copy link
Member

p-snft commented Feb 24, 2021

I think as an oemof project, it should also be located at https://github.com/oemof/hydropowerlib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants