Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible logging functionality #389

Closed
jowr opened this issue Feb 13, 2023 · 3 comments
Closed

Flexible logging functionality #389

jowr opened this issue Feb 13, 2023 · 3 comments

Comments

@jowr
Copy link
Contributor

jowr commented Feb 13, 2023

Hi and thank you for all the work you put into this library - very much appreciated.

We currently build a UI around the core functionality of TESPy and I thus need to capture some of the logging and printing output - either for rerouting it to the UI or for reporting progress, errors and results.

While working on this, I noticed that TESPy uses the root node logger from the logging framework. Would it be OK if I submitted a PR covering the following two points:

  1. Replace the root logger with a named logger (from the logging framework) that can be accessed and modified using a unique ID like TESPyRoot for example.
  2. Include the option to provide call-back functions to retrieve status messages instead of printing these messages directly to stdout?
@fwitte
Copy link
Member

fwitte commented Feb 13, 2023

Dear @jowr,

thank you for reaching out, that sounds like a very good idea! Is there anything I can help you with to get started easier on this?

Thank your for your contribution

Francesco

@jowr
Copy link
Contributor Author

jowr commented Feb 13, 2023

No, thanks for asking though. I am going to stitch up a PR and get back to you for a critical review 😁

@fwitte
Copy link
Member

fwitte commented Mar 28, 2023

Closed as completed by #390 / #391

@fwitte fwitte closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants