Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing component in COMP_TARGET_CLASSES #508

Closed
sertomas opened this issue Apr 29, 2024 · 4 comments · Fixed by #510
Closed

Missing component in COMP_TARGET_CLASSES #508

sertomas opened this issue Apr 29, 2024 · 4 comments · Fixed by #510

Comments

@sertomas
Copy link

When I save and read a network with a DiabaticCombustionChamber I get this error while reading the file: KeyError: 'DiabaticCombustionChamber'. I think this component is missing in network_reader.py/COMP_TARGET_CLASSES. Or is there a reason for that?

@fwitte
Copy link
Member

fwitte commented Apr 30, 2024

Hi @sertomas,

you are correct with that, I'll fix it and make a release asap.

Best

@fwitte
Copy link
Member

fwitte commented Apr 30, 2024

@sertomas, could you quickly test, if the changes on branch fix/#508-missing-imports-in-network-load make your use case work? Thanks!

@sertomas
Copy link
Author

Hi @fwitte it works now! :)

@fwitte
Copy link
Member

fwitte commented Apr 30, 2024

@sertomas: I released a new version, which includes the fix. Also, it is now possible to register your own components to the load_network method. See the what's new section on the docs. Thanks for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants