Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the network topology debugging #135

Merged
merged 3 commits into from Jan 7, 2020

Conversation

fwitte
Copy link
Member

@fwitte fwitte commented Jan 6, 2020

The solver will specify all connections attached to component
inlets and outlets that are used at least twice.

The solver will specify all connections attached to component
inlets and outlets that are used at least twice.
@pep8speaks
Copy link

pep8speaks commented Jan 6, 2020

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 45:80: E501 line too long (81 > 79 characters)
Line 1117:80: E501 line too long (88 > 79 characters)
Line 1125:80: E501 line too long (86 > 79 characters)
Line 1129:80: E501 line too long (83 > 79 characters)
Line 1943:80: E501 line too long (80 > 79 characters)

Line 542:67: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 555:67: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1234:35: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1299:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'

Comment last updated at 2020-01-07 09:29:03 UTC

@fwitte fwitte added this to In Progress in Release of version 0.2.0 Jan 7, 2020
@fwitte fwitte merged commit 07a79a1 into oemof_doc_review Jan 7, 2020
Release of version 0.2.0 automation moved this from In Progress to Done Jan 7, 2020
@fwitte fwitte deleted the improve/network_topology_debugging branch January 9, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants