Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature: CoolProp backend selection #174

Merged
merged 53 commits into from Apr 13, 2020
Merged

New feature: CoolProp backend selection #174

merged 53 commits into from Apr 13, 2020

Conversation

fwitte
Copy link
Member

@fwitte fwitte commented Apr 7, 2020 •
edited

The changes in this PR allow to select from the different backends in CoolProp and resolves #170.

@fwitte
Copy link
Member Author

fwitte commented Apr 7, 2020

Additional tests are needed to check

  • performance differences in the backends and
  • result accuracy.

@fwitte
Copy link
Member Author

fwitte commented Apr 7, 2020

Furthermore a test should be added, that tests if the mixture of a tespy_fluid with another fluid yields the same results as a mixture of the single fluids in regards to the method s_mix_pT.

@pep8speaks
Copy link

pep8speaks commented Apr 8, 2020 •
edited

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-13 19:15:45 UTC

fwitte added 26 commits April 8, 2020 11:45
@fwitte
Fix doctest
66cc069
@fwitte
Update test description
eae618d
@fwitte
Fix combustion chamber stoich doctest
e06c007
@fwitte
Fix PEP8 issues
3fbde51
@fwitte
Update What's New
e7e1c3a
@fwitte
Fix vapor fraction unit implementation
8b0b10d
@fwitte
Update h_os method
f927155
@fwitte
Rename backend to back_end
fcdb970
@fwitte
Remove debug printing
80e9109
@fwitte
Update generic derivative calculation
26be708
@fwitte
Fix value comparison by rounding
1ce1949
@fwitte
Readjust delta values for p and h in generic derivative
615903c
@fwitte
Fix network import example
94f585e
@fwitte
Remove IF97 from back end selection
4c1bc09
@fwitte
Remove rounding from test
f507738
@fwitte
Add fluid property back end test
e17012f
@fwitte
Try to fix travis issue, the tests run locally
b92a3e0
@fwitte
Remove test for travis
9687356
@fwitte
Another try
dc577d7
@fwitte
Next try
52d2417
@fwitte
Add a test for INCOMP backend
9a164bd
@fwitte
Add try for CoolProp IF97 back end error test
c4dfbd2
@fwitte
Tmin and Tmax are available for all fluids
5596086
@fwitte
Compare to None instead of str
35d9e7f
@fwitte
Add missing removal of stoichiometric combustion chamber lookup table
7ae2135
@fwitte
Add missing removal of stoichiometric combustion chamber lookup table
907a490
@fwitte fwitte merged commit 1012e13 into dev Apr 13, 2020
@fwitte fwitte deleted the feature/CoolProp_backend branch April 13, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The specification of the CoolProp backend can save calculation time
2 participants
@fwitte @pep8speaks