Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revision of the nework_reader module and network export #46

Merged
merged 18 commits into from
Jan 15, 2019
Merged

Revision of the nework_reader module and network export #46

merged 18 commits into from
Jan 15, 2019

Conversation

fwitte
Copy link
Member

@fwitte fwitte commented Dec 17, 2018 •
edited
Loading

Coverage Status

This was referenced Dec 17, 2018
Closed
Closed
@fwitte fwitte changed the title Network export replacing specific sources/sinks by subsystem interfaces Revision of the nework_reader module and network export Jan 10, 2019
@fwitte fwitte mentioned this pull request Jan 10, 2019
Closed
@fwitte
Copy link
Member Author

fwitte commented Jan 15, 2019

All bullets addressed, #44 not tested yet. @ShuangChen88: Could you check out this branch and test, if the issue persists? Thanks and have a nice day!

@fwitte fwitte merged commit a823cdb into dev Jan 15, 2019
@fwitte
Copy link
Member Author

fwitte commented Jan 15, 2019

merged

@fwitte fwitte deleted the features/export_with_interface branch January 15, 2019 11:26
@ShuangChen88
Copy link
Contributor

ShuangChen88 commented Jan 16, 2019 •
edited
Loading

@fwitte for issue #44 I have checked it with my test. It works now! Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fwitte @ShuangChen88