Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update request: php-excimer 1.1.1 #1952

Closed
1 task done
Krinkle opened this issue Apr 30, 2023 · 2 comments
Closed
1 task done

Update request: php-excimer 1.1.1 #1952

Krinkle opened this issue Apr 30, 2023 · 2 comments

Comments

@Krinkle
Copy link

Krinkle commented Apr 30, 2023 •
edited
Loading

Frequently asked questions

Is your feature request related to a problem? Please describe.

php-excimer 1.1.0 introduces support for Speedscope (ExcimerLog::getSpeedscopeData), which applications like Sentry PHP and excimer-ui-client depend on.

https://pecl.php.net/package-changelog.php?package=excimer&release=1.1.1

Changes in 1.1.0 (2023-03-13)
* Add ExcimerLog::getSpeedscopeData for Speedscope support.
* Add support for PHP 8.2.
* Fix leading semi-colon in ExcimerLog::formatCollapsed output.

Changes in 1.1.1 (2023-03-02)
* Restore support for PHP 7.1-7.3.

Describe the solution you'd like
Update the package.

Describe alternatives you've considered
N/A

Distribution (please complete the following information):

  • OS: Debian 11 Bullseye
  • Architecture: amd64
  • Repository: packages.sury.org

Package(s) (please complete the following information):

$ apt-cache policy php8.0-excimer
php8.0-excimer:
  Installed: 1.0.4-1+0~20221216.1+debian11~1.gbp44aab6
  Candidate: 1.0.4-1+0~20221216.1+debian11~1.gbp44aab6
  Version table:
 *** 1.0.4-1+0~20221216.1+debian11~1.gbp44aab6 500
        500 https://packages.sury.org/php bullseye/main amd64 Packages
        100 /var/lib/dpkg/status

Additional context

The sury.org packages are currently at 1.0.4. When I published excimer 1.1.0 in 2nd March 2023, I messed up and accidentally broke PHP 7.1-7.3 support. This has been fixed in excimer 1.1.1, published on 13th March 2023.
@Krinkle
Copy link
Author

Krinkle commented Jul 11, 2023

@oerdnj With Debian 13 Trixie now open, we've updated the package at https://salsa.debian.org/mediawiki-team/php-excimer/ and uploaded it to https://packages.debian.org/trixie/php-excimer. I hope that makes it easier to port to deb.sury.org as well!

@oerdnj
Copy link
Owner

oerdnj commented Feb 13, 2024

Updated

@oerdnj oerdnj closed this as completed Feb 13, 2024
wmfgerrit pushed a commit to wikimedia/integration-config that referenced this issue Mar 30, 2024
@Krinkle
jjb: Upgrade php-excimer to 1.2.1 in composer-test jobs
665fc94 
The upgrade happened implicitly as part of the image rebuild earlier
this month for T360420, since we simply install the package from the
current Debian release channel (via deb.sury.org) and upstream has
updated the package for us via
oerdnj/deb.sury.org#1952.

This in turn unblocks writing PHPUnit tests for WikimediaDebug's
performance/excimer-ui-client repo, which depends on php-excimer 1.1.0+,
which is when we introduced support for Speedscope.

```
./dockerfiles/debug-image dockerfiles/composer-package-php80/

nobody@cddf3ff8a3ae:/$ php -i | grep excimer
/etc/php/8.0/cli/conf.d/20-excimer.ini,
excimer
excimer support => enabled
excimer version => 1.2.1
```

```
./dockerfiles/debug-image dockerfiles/composer-package-php80/ 0.0.6
nobody@43b86e172b06:/$ php -i |  grep excimer
/etc/php/8.0/cli/conf.d/20-excimer.ini,
excimer
excimer support => enabled
excimer version => 1.0.4
```

Bug: T361412
Bug: T360420
Change-Id: I97a3629d5520d1fffd0348e2d89cd8bb33f4b3f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oerdnj @Krinkle