Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #74 #88

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Fix issue #74 #88

merged 3 commits into from
Apr 11, 2022

Conversation

youpong
Copy link
Contributor

@youpong youpong commented Apr 8, 2022 •
edited
Loading

This PR fixes issue #74.

run the following command to test.

$ cd src
$ prove

Changes

BOLD: difference from previous commit(3e7970a).

src/t/translation.t(new file)

  • You may need to run several times to reproduce. Because the issue depends on hash order.

src/lib/mrtg2/locales_mrtg.pm

  • not changed

translate/skelton.pm0

  • Increase version number(0.08 <- 0.07)

translate/brazilian.pmd

  • Change the regular expressions

src/bin/mrtg

  • Increase module locales_mrtg version number(0.08 <- 0.07)

.github/workflows/build-linux.yml

  • Add unit testing

@youpong youpong requested a review from oetiker as a code owner April 8, 2022 19:22
@youpong youpong mentioned this pull request Apr 8, 2022
Open
oetiker
oetiker approved these changes Apr 9, 2022
View reviewed changes
Copy link
Owner

@oetiker oetiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@oetiker
Copy link
Owner

oetiker commented Apr 9, 2022

now if the new tests were passing ....

@eribertomota
Copy link
Contributor

A good catch!

@youpong
Copy link
Contributor Author

youpong commented Apr 11, 2022

Made it pass the new tests.

@oetiker
Copy link
Owner

oetiker commented Apr 11, 2022

thanks!

@oetiker oetiker merged commit 7f6f367 into oetiker:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oetiker oetiker oetiker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youpong @oetiker @eribertomota