-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support raw sends of encrypted datasets #323
Conversation
1 similar comment
could you add a bit more documentation about the purpose of the raw switch ? |
reading your PR I get the impression that [raw] is not really optional ... and would break existing syntax |
I can revise the PR if you can suggest a preferred way to make the syntax optional. Easiest fix may be to move it after post-command. |
54358b8
to
0000bfc
Compare
I just pushed an update that moves raw to the end and adds a doc entry. |
An additional 'on|off' parameter can now be set on a destination to indicate that a 'raw' send should be used to transmit an encrypted dataset. This is useful for remote backup scenarios to an untrusted destination since data is not decrypted before transmitting. Unlike unencrypted datasets, the destination dataset must not exist prior to the initial send, so this commit also disables such checks when raw send is enabled.
0000bfc
to
ac7995c
Compare
I think we have API design issue here ... positional arguments in this structure are not really sustainable if more of them come. I would suggest the following: only mandatory arguments are positional (plus the two optional ones added earlier for backward compatibility). all optional argument follow the classic cli design principle where optional argument are written as
the optional arguments can appear in any order AFTER the @hadfl what do you think? |
I prefer that approach but am not familiar with how to modify that option parsing code. On a related note, I think |
Could this one be revived? I'd have use for this feature. |
I think we got this now |
An additional 'on|off' parameter can now be set on a destination to indicate that a 'raw' send should be used to transmit an encrypted dataset. This is useful for remote backup scenarios to an untrusted destination since data is not decrypted before transmitting. Unlike unencrypted datasets, the destination dataset must not exist prior to the initial send, so this commit also disables such checks when raw send is enabled.