Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain setting is not required #1

Closed
shadowhand opened this issue Nov 22, 2016 · 2 comments
Closed

Domain setting is not required #1

shadowhand opened this issue Nov 22, 2016 · 2 comments
Assignees
@ofbeaton
Labels
bug

Comments

@shadowhand
Copy link

The $domain property set by the constructor is not required. Any property that is protected (or public, but not recommended) can be set simply by setting the name in the $options array, as per this code.
@ofbeaton ofbeaton added the bug label Nov 22, 2016
@ofbeaton ofbeaton self-assigned this Nov 22, 2016
@ofbeaton
Copy link
Owner

Thanks for the report.

ofbeaton added a commit that referenced this issue Nov 22, 2016
@ofbeaton
Fixes #1 Made domain protected (shadowhand)
9bfd67c
@ofbeaton
Copy link
Owner

See additional fix for domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ofbeaton ofbeaton

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shadowhand @ofbeaton