Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ARCH=armv8 in Makefile (#2355) #2760

Closed
wants to merge 1 commit into from
Closed

Support ARCH=armv8 in Makefile (#2355) #2760

wants to merge 1 commit into from

Conversation

niklasf
Copy link
Contributor

@niklasf niklasf commented Jun 23, 2020

Tested with bench run after compiling with

  • g++ (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
  • clang version 3.8.1-24

on ThunderX CN8890.

No functional change.

@niklasf
Support ARCH=armv8 in Makefile (official-stockfish#2355)
d6f3b21 
Tested with bench run after compiling with

- g++ (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
- clang version 3.8.1-24

on ThunderX CN8890.

No functional change.
@niklasf niklasf mentioned this pull request Jun 23, 2020
Closed
@vondele vondele added the to be merged Will be merged shortly label Jun 23, 2020
@unaiic unaiic mentioned this pull request Jun 24, 2020
Closed
@unaiic
Copy link
Contributor

unaiic commented Jun 24, 2020

@vondele Maybe it could be merged with #2763 as well? Both requests reference the same file, and they seem to work well. Moreover, #2355 and #2731 could be closed.

@vondele vondele closed this in 527d832 Jun 24, 2020
@vondele
Copy link
Member

vondele commented Jun 24, 2020

Thanks for the code and the testing.

@daylen
Copy link
Contributor

daylen commented Jun 25, 2020

@niklasf Just FYI, I am fairly sure that armv8-a supports popcnt. So we could set popcnt = yes for armv8. Once we do that since we are using __builtin_popcountll() in the code, cross-compiling with clang does produce a binary with the ARM cnt instruction. Checked this by disassembling the resulting binary. I don't have an ARM processor to actually run it yet but maybe you could try that out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
to be merged Will be merged shortly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@niklasf @unaiic @vondele @daylen