Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile (#2731) #2763

Closed
wants to merge 2 commits into from
Closed

Update Makefile (#2731) #2763

wants to merge 2 commits into from

Conversation

unaiic
Copy link
Contributor

@unaiic unaiic commented Jun 23, 2020

Clean and organize uppercase and spaces; also set 64 bit as standard

@stockchess
Copy link

suggest add -flto change #2731

@unaiic
Copy link
Contributor Author

unaiic commented Jun 24, 2020

Ok, will take a look at it.

@unaiic unaiic changed the title Update Makefile Update Makefile (#2731) Jun 24, 2020
@unaiic
Copy link
Contributor Author

unaiic commented Jun 24, 2020

Could someone please check that it works for MinGW with -flto under Windows?

@unaiic unaiic mentioned this pull request Jun 24, 2020
@stockchess
Copy link

stockchess commented Jun 24, 2020

works great with mingw/msys2 thx

@unaiic
Copy link
Contributor Author

unaiic commented Jun 24, 2020

It is ready then. Thank you too!

@unaiic
Copy link
Contributor Author

unaiic commented Jun 24, 2020

@vondele As they reference the same file, could it be merged along with #2760 as one?

@vondele
Copy link
Member

vondele commented Jun 24, 2020

Thanks... try to keep PRs limited to one item, and of code you have written specifically, that makes it easier for me to merge.

@unaiic
Copy link
Contributor Author

unaiic commented Jun 24, 2020

Ok, got it. Thank you for your time and patience!

@unaiic unaiic deleted the umake branch June 30, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants