-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Little fix for cygwin&msys2 environment #3569
Conversation
The Cygwin environment has two g++ compilers, each with a different problem for compiling Stockfish at the moment: (a) g++.exe : full posix build compiler, linked to cygwin dll. => This one has a problem embedding the net. (b) x86_64-w64-mingw32-g++.exe : native Windows build compiler. => This one manages to embed the net, but has a problem related to libgcov when we use the profile-build target of Stockfish. This patch solves the problem for compiler (b), so that our recommended command line if you want to build an optimized version of Stockfish on Cygwin becomes something like the following (you can change the ARCH value to whatever you want, but note the COMP and CXX variables pointing at the right compiler): ``` make -j profile-build ARCH=x86-64-modern COMP=mingw CXX=x86_64-w64-mingw32-c++.exe ``` closes #3463 No functional change
I'll merge this one shortly |
seems like this again broke something now compiling under linux within fishtest. Might need another revert official-stockfish/fishtest#952 |
It's unfortunate this silently breaks fishtest because the solution was tested after the revert of the original patch and seemed to work perfectly. I think this isn't our bug per se but something going wrong with what the ffishtest worker assumes is its current working directory, either because of a bug in |
Look consistent and no directory juggling |
tmp_dir = tempfile.mkdtemp(dir=worker_dir)
try:
os.chdir(tmp_dir)
with open("sf.gz", "wb+") as f:
f.write(
requests.get(
github_api(repo_url) + "/zipball/" + sha, timeout=HTTP_TIMEOUT
).content
)
zip_file = ZipFile("sf.gz")
zip_file.extractall()
zip_file.close()
os.chdir(glob.glob(os.path.join(tmp_dir, "*/src/"))[0]) Looks like directory juggling to me, and I don't know if |
The error with the fishtest worker only occurs if the The patch is fine but exposes a |
The Cygwin environment has two g++ compilers, each with a different problem for compiling Stockfish at the moment: (a) g++.exe : full posix build compiler, linked to cygwin dll. => This one has a problem embedding the net. (b) x86_64-w64-mingw32-g++.exe : native Windows build compiler. => This one manages to embed the net, but has a problem related to libgcov when we use the profile-build target of Stockfish. This patch solves the problem for compiler (b), so that our recommended command line if you want to build an optimized version of Stockfish on Cygwin becomes something like the following (you can change the ARCH value to whatever you want, but note the COMP and CXX variables pointing at the right compiler): ``` make -j profile-build ARCH=x86-64-modern COMP=mingw CXX=x86_64-w64-mingw32-c++.exe ``` closes official-stockfish#3569 No functional change
No description provided.