Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of empty strings in uci options and reassigning of the log file. #3655

Closed
wants to merge 2 commits into from
Closed

Fix handling of empty strings in uci options and reassigning of the log file. #3655

wants to merge 2 commits into from

Conversation

Sopel97
Copy link
Member

@Sopel97 Sopel97 commented Aug 13, 2021

Fixes #3650

@Sopel97
Fix no way to pass empty string through uci option
13bab62
@Sopel97
Fix "Debug Log" not being properly reassigned while already open.
6e5cd04 
The following would previously write to a.txt, now writes to b.txt:
setoption name Debug Log File value a.txt
setoption name Debug Log File value b.txt
go depth 10
@jomega-github
Copy link

jomega-github commented Aug 13, 2021 •
edited
Loading

Fixes #3650

Thanks Sopel97

@vondele vondele added the to be merged Will be merged shortly label Aug 20, 2021
@vondele vondele closed this in ccf0239 Aug 20, 2021
@man4
Copy link

man4 commented Aug 20, 2021

This seems to break the case when EvalFile is set to blank:

setoption name EvalFile value
go infinite
info string ERROR: If the UCI option "Use NNUE" is set to true, network evaluation parameters compatible with the engine must be available.
info string ERROR: The option is set to true, but the network file  was not loaded successfully.
...

It's useful to set this to blank in a GUI (e.g. cutechess GUI) so that when you download new dev versions with new nets, you don't have to manually change the EvalFile parameter each time. I thought this was supported functionality (but I could be wrong)

@Sopel97
Copy link
Member Author

Sopel97 commented Aug 20, 2021 •
edited
Loading

I'd think the gui would have an option to just ignore some settings and rely on defaults? This is quite unfortunate, I'll try to come up with a "fix".

@Sopel97
Copy link
Member Author

Sopel97 commented Aug 20, 2021

@man4 see #3668

@man4
Copy link

man4 commented Aug 20, 2021

looks good, thanks!

Joachim26 pushed a commit to Joachim26/StockfishNPS that referenced this pull request Mar 28, 2023
@Sopel97 @Joachim26
Improve handling of the debug log file.
bd5a497 
Fix handling of empty strings in uci options and reassigning of the log file

Fixes official-stockfish#3650

Closes official-stockfish#3655

No functional change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
to be merged Will be merged shortly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"setoption name debug log file value" does not close previous debug log file
4 participants
@Sopel97 @jomega-github @man4 @vondele