[RFC] Make UCI option handling more type-safe and the code cleaner. #3674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch cleans up the syntax and semantics of the code handling UCI options. The following changes have been done:
OptionsMap
class that holds both ordered an unordered optionsOptions
was moved to theUCI
namespaceNNUE::verify
no longer uses a hacky way of getting the default nnue file nameallowEmpty
field is added to each option, see "allowEmpty" property for UCI options. Disallow empty values for net file. #3668stod
instead of stof for readingdouble
optionsdouble
option values asint
operator<<
for adding options to theOptionsMap
I want to get some feedback regarding this, which changes are good and which are bad in your eyes, and whether there's a chance of getting this merged. If this is to be merged we will need to test for non-regression on fishtest and also verify whether the tuning works correctly.