Modernize code base a little bit #4327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
StefanoD
commented
Jan 7, 2023
•
StefanoD
commented
- Removed sprintf() which generated a warning, because of security reasons.
- Replace NULL with nullptr
- Replace typedef with using
- Do not inherit from std::vector. Use composition instead.
vondele
reviewed
Jan 7, 2023
UniQP
reviewed
Jan 7, 2023
UniQP
reviewed
Jan 7, 2023
Joachim26
pushed a commit
to Joachim26/StockfishNPS
that referenced
this pull request
Jan 9, 2023
Removed sprintf() which generated a warning, because of security reasons. Replace NULL with nullptr Replace typedef with using Do not inherit from std::vector. Use composition instead. optimize mutex-unlocking closes official-stockfish#4327 No functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.