IE11 Support (w/o polyfill) #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@XaserAcheron makes sense to me and glad I could help out! |
|
Released with |
|
Aces! Thanks for the quick response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a simple one(two?)-liner that fixes IE11 support. The gist is
for... ofgets translated by Babel into a bit of code that usesSymbol, which doesn't exist in IE11 (see here for a related issue from another repo). Those of us not using the Babel (or some other Symbol) polyfill are a bit out of luck.Sadly, this does mean replacing the pretty
for... ofloop with an ugly ol'for(let i =...construct, but IMO it's better to make this change than require use of a polyfill for a single line of syntactic sugar.[On a positive note, huge +1 to this addon otherwise. It was posted right at exactly the time I needed to implement this functionality into an app during its last week of development, so you unwittingly prevented a huge dev crunch. Kudos!]