Updates for ember-data 2.14+ #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offirgolan
requested changes
Jan 29, 2018
package.json
Outdated
| @@ -24,15 +24,13 @@ | |||
| "test": "ember try:each" | |||
| }, | |||
| "dependencies": { | |||
| "ember-assign-polyfill": "^2.0.1", | |||
There was a problem hiding this comment.
This is needed for Ember 2.4-lts and below
package.json
Outdated
| "ember-cli-babel": "^6.0.0", | ||
| "ember-concurrency": "^0.8.5", | ||
| "ember-getowner-polyfill": "^1.2.3" |
There was a problem hiding this comment.
This is needed for Ember 2.4-lts and below
addon/mixins/copyable.js
Outdated
| @@ -192,9 +192,9 @@ export default Ember.Mixin.create({ | |||
| Supports Ember Data 2.5+ | |||
| */ | |||
| if (meta.kind === 'hasMany') { | |||
| copyRef.hasManyRelationship.addRecords(ref.hasManyRelationship.members); | |||
| copyRef.hasManyRelationship.addInternalModels(ref.hasManyRelationship.members); | |||
There was a problem hiding this comment.
Can we check if addInternalModels exists and if so, using it instead of addRecords? That way this change is backwards compatible.
… (ember-data < 2.14)
onumossn
force-pushed
the
ember-data-2.14-fix
branch
from
8318a50
to
407c44e
Compare
|
updated |
|
Are any other changes required? |
offirgolan
approved these changes
Jan 30, 2018
|
@onumossn nope. Thanks for making those changes! |
|
Released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace addRecords with addInternalModels and update ember data version