Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newer versions of ember-concurrency #29

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
2 participants
@jakesjews
Copy link
Contributor

commented May 2, 2019

Loosen the ember-concurrency version to allow deduping

@jakesjews jakesjews changed the title allow newer versions of ember-concurrency Allow newer versions of ember-concurrency May 2, 2019

@@ -28,7 +28,7 @@
},
"dependencies": {
"ember-cli-babel": "^7.1.2",
"ember-concurrency": "^0.8.27",
"ember-concurrency": "^0.8.27 || ^0.9.0 || ^0.10.0",

This comment has been minimized.

Copy link
@offirgolan

offirgolan May 2, 2019

Owner

Would ~0.8.27 be a simpler and longer solution to this?

This comment has been minimized.

Copy link
@jakesjews

jakesjews May 2, 2019

Author Contributor

I think that will restrict it further to only versions within 0.8.x instead of allowing it to be a higher version

This comment has been minimized.

Copy link
@jakesjews

jakesjews May 2, 2019

Author Contributor

0.x versions are kinda weird in that using ^ will only bump the third number since below version 0 considers the second number to be major versions

This comment has been minimized.

Copy link
@offirgolan

offirgolan May 2, 2019

Owner

Yeah, you're totally right. I 100% spaced on this. Maybe something like this >=0.8.0 < 1.0.0 ?

This comment has been minimized.

Copy link
@jakesjews

jakesjews May 2, 2019

Author Contributor

i think that could work the only downside might be if theres a version 0.11.0 and it has a breaking change thats incompatible with this library

This comment has been minimized.

Copy link
@offirgolan

offirgolan May 2, 2019

Owner

Alright, I'll just merge this and patch release it. I can always come back to it 😄

@offirgolan offirgolan merged commit bfaf67c into offirgolan:master May 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@offirgolan

This comment has been minimized.

Copy link
Owner

commented May 2, 2019

Published with v1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.