Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow e-c ^2.0.0-rc.1 #55

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Conversation

miguelcobain
Copy link
Collaborator

In the same spirit as #30, we can allow ember-concurrency versions 2.0.0-rc.1+.

This is actually mentioned in the migration guide: https://github.com/machty/ember-concurrency/blob/master/UPGRADING-2.x.md#packagejson

@miguelcobain
Copy link
Collaborator Author

Hey @offirgolan

Noticed that this project is a bit abandoned. I'm willing to take ownership of it if you'd like that.

@miguelcobain
Copy link
Collaborator Author

@offirgolan can we merge and release this one, please?

@offirgolan
Copy link
Owner

@miguelcobain I'm happy to give you ownership. I can add you as a collaborator (or transfer this repo to you) and give you npm publish permissions.

Let me know what you'd prefer. I would just need your NPM user info so I can add you.

@offirgolan offirgolan merged commit 45ce37c into offirgolan:master Nov 10, 2022
@miguelcobain
Copy link
Collaborator Author

@offirgolan adding as collaborator would be fine. I go by miguelcobain, both on github and npm.

@offirgolan
Copy link
Owner

Ok great! I've published v1.2.0 with this PR and added you as a collaborator and npm owner. Let me know if there's anything else you need!

Thanks for taking this up!

@miguelcobain
Copy link
Collaborator Author

@offirgolan seems like I still don't have npm access, so I can't publish new versions. username is miguelcobain, please. 🙏

@offirgolan
Copy link
Owner

@miguelcobain I re-sent the invitation. Let me know if you don't see it.

@miguelcobain
Copy link
Collaborator Author

@offirgolan I got it! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants