Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Memory Region, Multi Domain, Multi Endpoint, Recv Cancel, & Unexpected_msg FT #689

Merged
merged 5 commits into from
Jul 22, 2017

Conversation

nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Jul 20, 2017

Implemented new Functional tests for verifying:

  • Multiple Memory Regions in use for sending messages between client/server to specified memory regions
  • Multiple Domains in use for sending messages between client/server to specified domains
  • Multiple Endpoints communicating between client/server created on a single domain.
  • Cancelling a pending Receive and retrieving the correct error log.
  • Unexpected messages handled by the provider

Implemented support in the common infrastructure for:

  • allowing easier setup of new RDM/DGRAM endpoints
  • increase ease of init for connect/accept FI_EP_MSG endpoints for multi ep init
  • added new init for CM (connect/accept) FI_EP_MSG testing
  • configurable address vector size
  • configurable tag for tagged messaging
  • configurable option to enable verbose printing
  • common init for new address vectors
  • function pointer to customize allocating memory regions for tests

Signed-off-by: nrspruit neil.r.spruit@intel.com

 -simple/multi_mr functional test (fi_multi_mr)
   - Performs multikey/multi memory region ping pong testing
   - Uses fi_mr_bind on each memory region to track individual writes
   - Uses separate key for each memory region to target each write call
   - Performs data verification on the result from each write
   - Allows for testing FI_EP_MSG/FI_EP_RDM/FI_EP_DGRAM
   - test added to "simple" test list
  -common/shared
   - Added ft_mr_alloc_func function pointer to shared.h
   - When set, allocation of memory regions done by ft_mr_alloc_func

Signed-off-by: nrspruit <neil.r.spruit@intel.com>
  -simple/rdm_multi_domain functional test (fi_rdm_multi_domain)
    - Uses multi-domains each with memory region for ping pong RMA testing
    - Uses fi_mr_bind on each memory region to track individual writes
    - Uses separate domain ep address to target each write call
    - test added to "simple" test list
  -common/shared
    - Added init functions for Address Vectors
    - ft_init_av_addr for passing ep addresses between client and server
    - ft_init_av_dst_addr for init dst addr on server and server's ep
          addr on client

Signed-off-by: nrspruit <neil.r.spruit@intel.com>
  -simple/multi_ep functional test (fi_multi_ep)
    - Allows users to create n number of active endpoints
    - Supports dgram,msg,rdm endpoint types
    - Sends messages from each EP to the corresponding EP on the remote host
    - Supports data validation

  -simple/multi_mr
    - Updated to use common init function for cm testing

  -common/shared
    - Added support for setup of eps with user specified resources
    - Added functions to split up CM connect/accept functionality
    - Added init function for cm testing
    - Added option for setting the default address vector's size

Signed-off-by: nrspruit <neil.r.spruit@intel.com>
  -simple/recv_cancel functional test (fi_recv_cancel)
    - Tests cancelling a single pending recv
    - Verifies that the error entry is valid
    - Supports dgram,msg,rdm endpoint types
    - Added to simple test list

  -common/shared
    - Added ft_tag for setting tags in send/recv ops
    - Added verbose option for tracking enabling of prints
      in a test

Signed-off-by: nrspruit <neil.r.spruit@intel.com>
  -simple/unexpected_msg functional test (fi_unexpected_msg)
    - Tests sending N messages to N recvs as unexpected messages
    - Allows for testing with cq_sread or cq_read
    - data verification on messages is available
    - Configurable number of concurrent messages and iterations
    - Configurable size for the unexpected messages
    - Supports dgram,msg,rdm endpoint types
    - Added to simple test list

Signed-off-by: nrspruit <neil.r.spruit@intel.com>
@shefty
Copy link
Member

shefty commented Jul 20, 2017

@jsquyres - The DCO sign-off-by check is failing for this PR, but our check works fine. Manually inspecting the patches, everything looks okay to me. Any idea why DCO fails?

@nrspruit nrspruit force-pushed the unexpected_msg_test branch 2 times, most recently from 6c1768e to c2a702b Compare July 20, 2017 22:13
@nrspruit nrspruit changed the title Multi Endpoint, Recv Cancel, & Unexpected_msg FT Multi Memory Region, Multi Domain, Multi Endpoint, Recv Cancel, & Unexpected_msg FT Jul 20, 2017
Copy link
Contributor

@aingerson aingerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #627

Copy link
Contributor

@aingerson aingerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #628

@shefty shefty merged commit d457082 into ofiwg:master Jul 22, 2017
@jsquyres
Copy link
Member

I filed a question on the DCO Probot project asking why it returned a failure on this PR (dcoapp/app#17). I suspect it's because the name does not match between the commit author and the DCO signed off line, but let's wait to see what the project authors say.

@nrspruit
Copy link
Contributor Author

Thank you jsquyres for posting the question, I had changed the commits to nrspruit instead of Neil Spruit as they failed with that too, I have a feeling that my original may have had a character off and that is why the issue, thank you for following up and my next pull request will follow the correct guidelines. Thank you very much for your time!

@nrspruit nrspruit deleted the unexpected_msg_test branch September 29, 2017 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants